Re: [community-group] Add a `$private` property for tokens (#110)

Just a note regarding this issue

Here I already setup a PR to achieve pretty much 
https://github.com/amzn/style-dictionary/pull/704
But the idea was abandoned, since it is a breaking change, and Style Dictionary people were trying to avoid this scenario.

That's why it was suggested and implemented the idea of built-in filters.

You can raise the discussion there. 

I'm fine with the way I implemented, since I had scenarios where few design tokens needed to be filtered out. If you need to remove a group, it sounds logical wrong to have an entire set of design tokens that needed to be removed, but maybe I'm not foreseeing a situation like this.

In that case, a custom filter could be a solution?


-- 
GitHub Notification of comment by silversonicaxel
Please view or discuss this issue at https://github.com/design-tokens/community-group/issues/110#issuecomment-1030346235 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Friday, 4 February 2022 21:02:03 UTC