Re: [community-group] Group & file level properties (#72)

Thanks everyone for your comments. There's some interesting points being made and we're planning to discuss them at an upcoming spec editors meeting.

I think a few ideas & concerns have been raised in this thread, so I'll attempt to call out and summarise them here. Please comment if you feel this isn't accurate or I've missed out something.

1. Is it OK for some group properties to be inherited by child tokens (e.g. `type`) and others apply to the group itself (e.g. `description`)
1. Is it OK for groups to have properties that are inherited by child tokens _at all_?
    * Concerns have been raised that this might make the format harder to understand and/or parse. Also diffing could become tricky in some situations as the same information could be written in several ways.
1. Assuming we want groups to be able to set a default type for tokens within that do not set their own explicit type, should we name that group propert something other than `type` to avoid confusion? (`childrenType`, `tokenProperties.type` and `contains` have all been proposed as alternatives)

-- 
GitHub Notification of comment by c1rrus
Please view or discuss this issue at https://github.com/design-tokens/community-group/issues/72#issuecomment-992631352 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Monday, 13 December 2021 16:09:47 UTC