Test cases (batch 3) from Peter

Hi Peter,

thanks for the next round of test cases as submitted here:

     https://github.com/w3c/data-shapes/pull/54

Among them are tests that verify that a SHACL Core implementation does 
not accidentally also handle SHACL-SPARQL features. In order to support 
such tests, I have added an optional flag to the test harness, as 
described here:

https://github.com/w3c/data-shapes/commit/abcf2cb9ab591870240d37ebabcaedcbf5f1bcbd

In the commit above I have added such mf:requires triples to some of 
your tests. Please double-check that these changes reflect the intention 
of the test case.

I then spent an hour or so trying to find the three subtle bugs in your 
next test case; fixed:

https://github.com/w3c/data-shapes/commit/2359a8704b078f4259a0eb0453f42afb563b7daf

and then further time consuming errors, as fixed:

https://github.com/w3c/data-shapes/commit/4f46e168eeb99c8176dd9dc70c6efec88cc34e23

Please don't submit test cases unless you have run them yourself or 
otherwise ensured quality. Also the formatting of the source code is 
very poor, making it difficult to decipher. I have a lot of other things 
in my queue, such as the 11 new GitHub issues that you have submitted 
today. May I remind you of the "sloppiness" that you have complained 
about countless times while reviewing the SHACL spec?

Holger

Received on Thursday, 20 April 2017 05:46:44 UTC