Re: CR: Generating JSON from Tabular Data on the Web

Thanks for detailed comments. They’re being tracked on GitHub [1] and I’ll address them shortly.

Gregg Kellogg
gregg@greggkellogg.net

[1] https://github.com/w3c/csvw/issues/679

> On Jul 17, 2015, at 9:16 AM, timeless <timeless@gmail.com> wrote:
> 
> http://www.w3.org/TR/2015/CR-csv2json-20150716/
> 
>> it MAY be possible to organise [sic] the objects associated with those subjects such that some objects are nested within others
> 
> See earlier feedback [1] on en-gb/en-us
> 
>> We are on Github [2]
>> through some application specific API-s [3].
>> [reference]
> 
> Hopefully feedback [1][2][3] I've sent previously can be applied to
> each of the four specifications without me actively calling out the
> same comments on each (I will obviously call out spelling errors
> throughout, although those really shouldn't be present in CR
> documents...).
> 
>> the edge relating M and N MUST be modifed [sic] such that the
> 
>> Only the base annotation value is used to determine the primitive type used wihtin [sic] the JSON output.
> 
>> The key words MAY and MUST are to be interpreted as described in [RFC2119].
> ...
>> no further action should be taken for this instance of Vurl.
> 
> note that in this document, `should` isn't an rfc word...
> 
>> An object is defined in JSON ([RFC7159]) as unordered collection of zero or more name-value pairs, where a name is a string and a value is a string, number, boolean, null, object, or array.
> 
> as => as an
> a name => name
> a value => value
> 
>> including information about table schemas and columns specified therein, foreign keys, table direction, transformations etc.
> 
> missing `,` before `etc.`
> 
>> If name N occurs more than once within object Si, the name-value pairs from each occurrence of name N MUST be compacted to form a single name-value pair with name N and whose value is an array containing all values from each of those name-value pairs.
> 
> If N occurs once with value [1,2] and once with value [3,4], is the
> result {"N":[1,2,3,4]} or {"N":[[1,2],[3,4]]} ?
> I assume the latter, but think the text could use clarification.
> 
>> One of the main constituents of graphs; in such data structures edges are used to establish relationships among vertices.
> 
> missing `,` before `edges` -- alternatively you could reword using `an
> edge is ...`
> 
>> A collection of disjoint trees. For the purpose of this algorithm, the order of the trees are important, i.e., forests can also be viewed as a sequence of roots.
> 
> the trees => trees
> 
>> A dedicated vertex in a tree; a root is not the child of any vertex.
> 
> any => another
> 
>> One of the main constituents of graphs; in such data structures a vertex usually holds further information or data.
> 
> insert `,` after `structures` -- note that this sentence structure
> varies slightly from `edges` above.
> 
>> This clause in the algorithm prevents circular loops being created.
> 
> insert `from` before `being`
> 
>> Furthermore, because the URL-list contains value URLs that occur only once for the current row, object Si cannot be a descendant of an intermediate vertices in the tree.
> 
> drop `an`
> 
>> Specifications for such annotation processes should specify how these annotations should be converted into RDF.
> 
> How is this relevant to a document about JSON?
> 
>> In addition to compacting values of property URLs,
>> URLs which ware [sic] the value of @type used within the notes and non-core annotations are compacted according to the rules as defined in URL Compaction in [tabular-metadata].
> 
> were? are?
> 
> 
> 
> 
> 
> [1] https://lists.w3.org/Archives/Public/public-csv-wg-comments/2015Jun/0002.html
> [2] https://lists.w3.org/Archives/Public/public-csv-wg-comments/2015Jul/0000.html
> [3] https://lists.w3.org/Archives/Public/public-csv-wg/2015Jul/0060.html
>

Received on Friday, 17 July 2015 16:25:09 UTC