Re: [csswg-drafts] Proposal: Custom CSS Functions & Mixins (#9350)

I really like how you've fleshed this out. A few thoughts/questions:

- What's the purpose of declaring `@contents` in the `@mixin` prelude? 
- I like the way mixin authors can provide fallback contents. Maybe worth an example? I'm less sure about applying unused apply-side contents as nested rules. If the mixin doesn't use the contents, I think we might want to ignore those declarations.
- Example 18 doesn't show an `em` parameter being passed to the mixin.
- It might be helpful to have more explicit examples for how custom properties and environment variables / mixin parameters can or can't be used together. I believe it's explained by being similar to relative units, but it's not shown in any of the examples.

Overall I think this draft does a good job solving some complex problems - allowing for private logic, allowing for parameters that work in at-rules, etc. Nice work.

-- 
GitHub Notification of comment by mirisuzanne
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/9350#issuecomment-3079523713 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Wednesday, 16 July 2025 17:14:24 UTC