Re: [csswg-drafts] [css-rhythm-1] block-step-size doesn't handle collapsed margins well (#11514)

Sorry, you're misunderstanding my example (caused at least partially by my own misunderstanding of the resolution a while ago). See:

> (Note, these examples depend on today's resolution to make block-step-size inherit, but that's not important for what's happening. It would be identical if you manually specified the property on everything you want to be aligned.)

I was wrong about the resolution--we *didn't* resolve that it inherited--but that was the intent when I was writing them. Assume all the elements have the same block-step-size.

-------

> The guarantee in the spec is only that the outer height will be a multiple of the block step. Thus, when margins collapse, you will only get the desired result if that outer element has the largest margin.

Yes, that's the exact point of this issue. ^_^ If a block-step-size'd element contributes a smaller margin in a collapsing set, *or* if *two* size'd elements collapse their margins together (even if they have the same margin; even if they have *zero* margins, but gain margins *from the step-size*)

Like I said, the example image in the spec *only* works because all the paragraphs have 0 margin, and the step-size'd elements aren't siblings, so there's no margin collapse happening *at all*.

> The rule in the spec is very naive, and it was chosen to simplify the calculation, relying on the fact that in many cases, the outermost element carries the largest margin. We might want to revisit that decision and add more intelligent handling for collapsed margins.

Yeah, my point is that the spec is *too naive*, to the point that the feature doesn't work in practice. It needs *something* to make it actually work as intended in the common case.

-- 
GitHub Notification of comment by tabatkins
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/11514#issuecomment-2622449872 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Wednesday, 29 January 2025 17:55:13 UTC