Re: [csswg-drafts] [css-view-transitions-1] finished promise timing (#12442)

A follow-up question here: there are two options of changing this timing, and I'm not sure which one is better

1.
   - update the rendering happens, which posts a task to complete
   - in a task, we run the finished promise while ::view-transition is still present
   - in the same task, we clean up ::view-transition and all transition related things

or

2.
   - update the rendering happens, which posts a task to complete
   - in a task, we clean up ::view-transition and all transition related things
   - in the same task, we run the finished promise without any transition related things

The latter is a bit hard to test reliably (or at least I haven't figured out a good way), since any kind of test becomes indistinguishable from us not posting any tasks to do the clean up which is the thing we want to avoid.

I'm leaning towards 1 because it allows the developer an opportunity to still look at the final state of the view transition objects in the finished promise (and it's easy to test :) )

@nt1m @emilio wdyt?



-- 
GitHub Notification of comment by vmpstr
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/12442#issuecomment-3179682718 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Tuesday, 12 August 2025 14:49:35 UTC