- From: Mason Freed via GitHub <sysbot+gh@w3.org>
- Date: Fri, 13 Sep 2024 20:43:54 +0000
- To: public-css-archive@w3.org
> I would prefer punting this until we've discussed general design principles for `appearance: base` in #10866 which would influence this issue somewhat. I really believe thinking about this holistically aside outside of just one single form control is important to not repeat mistakes that were previously done. Love this approach, by the way. I think it's a great idea to set down some guiding principles that we can refer back to as we design all of the controls. I added a few comments on https://github.com/w3c/csswg-drafts/issues/10866#issuecomment-2350130260. > * The checkmark icon deserves its own pseudo (::check? maybe, something that's reusable with for checkbox/radios) Makes sense. We were fairly conflicted on the use of `::before`. One possibility is `::marker` but that's got other restrictions that might not make sense for `<select>` use cases. So maybe `::check` or `::checkmark`. > * The dropdown icon deserves its own pseudo (::select-arrow? not super convinced by the name myself, but 🤷 ) Makes sense. > * `select::picker(select)` -> `::picker(select)` Agree. > * Styles should be minimal: `::picker()` probably shouldn't include a box-shadow Likely fine, though the drop-shadow does help users distinguish that this is a popover picker "above" the in-page display. Perhaps we could find a less opinionated set of values? > * There's a lot of uses of system colors, I know that's prior art, but we're thinking of dropping that for `appearance: base` across the board, since in 100% of the cases, people want to override it The really nice thing about system colors, though, is that they handle dark mode. We believe the defaults for all controls should work well in both light and dark mode. Instead of system colors, we could use `light-dark()` but that just feels like more work for not much benefit, when the system colors do that already. > * There's use of custom fonts, we're also thinking `appearance: base` should probably just inherit the font for all controls since a custom font probably one of the annoying defaults for form controls. Makes sense, and agree with the annoying defaults comment. -- GitHub Notification of comment by mfreed7 Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/10857#issuecomment-2350131328 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Friday, 13 September 2024 20:43:55 UTC