Re: [csswg-drafts] [css-values-4][Editorial] `<condition>` type that other specs reference (#10457)

Some minor things...

I do not understand what the plural (emphasized below) refers to:

  > The `<boolean[]>` notation wraps another value type in the square brackets within it, e.g. `<boolean[ <test> ]>`, and represents that value alone as well as boolean combinations of **those values** [...]

I think *"evaluates"* is more appropriate than *"represents"* (which is already used in the quote above):

  > The `<boolean[]>` production **represents** a true, false, or unknown value [...]

I think `<boolean>` should be `<boolean[ <test> ]>` on the second line:

  > ```
  > <boolean[ <test> ]> = not <boolean-group> | ...
  > <boolean-group> = <test> | ( <boolean> ) | <general-enclosed>
  > ```

`<size-query>` does not exist and should be [`<size-feature>`](https://drafts.csswg.org/css-conditional-5/#typedef-style-feature):

  > ```
  > <container-query> = <boolean[ <cq-test> ]>
  > <cq-test> = (<size-query>) | style( <style-query> ) | scroll-state( <scroll-state-query> )
  > <size-query> = <boolean[ ( <size-feature> ) ]> | <size-feature>
  > <style-query> = <boolean[ ( <style-feature> ) ]> | <style-feature>
  > <scroll-state-query> = <boolean[ ( <scroll-state-feature> ) ]> | <scroll-state-feature>
  > ```

---

Perhaps syntax attribute names should be considered, noting that authors can now specify a value including a `<syntax>`. For example, `<number range=[0,∞] unit=px>` and `<boolean from=[<test>]` or similar.

-- 
GitHub Notification of comment by cdoublev
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/10457#issuecomment-2449338191 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Thursday, 31 October 2024 08:47:41 UTC