Re: [csswg-drafts] [css-values] A way to dynamically construct custom-ident and dashed-ident values (#9141)

> > @bramus Nit, but I think this should be sufficient?
> > ```
> > <ident-fn> = ident(<ident-args>+);
> > <ident-args> = [<string>  | <ident-fn>]+
> > ```
> 
> I see you have a double `+` in the syntax … I think the one after `<ident-args>+` can be dropped, no? Or maybe you meant `ident(<ident-args>#)` to allow multiple options _(in which the 1st non-empty one wins)_?

Oops, yes!

> > * `attr()` returns a string, so it's already included in `<string>`
> > * Provided the `var()` returns a `<string>`, it should be already allowed?
> 
> That depends on what `<attr-type>` was passed into `attr()` in the first case and how the property was registered in the second.

Do we want to allow `attr()` when it's NOT a string or ident? (maybe we do, it's not unreasonable! We already have the serialization...)

> > * What is the use case for `<ident-fn>` as an arg to another `<ident-fn>`?
> 
> I had a good reason but can’t see to recall it right now … hmmm.

If it produces an `<ident>` and we allow `<ident>` that should cover it.


-- 
GitHub Notification of comment by LeaVerou
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/9141#issuecomment-2436716059 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Friday, 25 October 2024 03:06:45 UTC