Re: [csswg-drafts] [css-color-4] Gamut mapping pseudocode is confusing (#10226)

@nex3 I was involved in ensuring the Color.js approach was implemented according to the intention of the spec. I won't deny though that the spec, as it is currently written, requires the reader to infer the intention which is not ideal.

> otherwise, if inGamut(current) is false carry out these steps

This statement mentions "if the color is `inGamut(current)` is false", but if `min_inGamut` is `false`, we can assume the color is not in gamut even if we have not performed an explicit `inGamut()` check.  So, yes, this is confusing and should be rephrased.

-- 
GitHub Notification of comment by facelessuser
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/10226#issuecomment-2065534713 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Friday, 19 April 2024 00:30:11 UTC