- From: Noam Rosenthal via GitHub <sysbot+gh@w3.org>
- Date: Sat, 09 Sep 2023 13:08:25 +0000
- To: public-css-archive@w3.org
When I look at the Svelte example, seems like they need it because of their API shape - the update of the DOM happens between resolving `onNavigate` and resolving `navigation.complete`. So in their case it would look like `onNavigate(() => document.startViewTransition(() => navigation.complete).beforeDOMUpdate);` This means that to make this work correctly, also `navigation.complete` has to reject if there was an error during navigation (to keep the behavior of skipping the transition if the update fails). I'm not sure if this API shape makes this clear. So this dual-promise technique would work for Svelte (and perhaps for Angular in your case), but perhaps if we wanted to make it clear in the API it needs to mandate a dual promise, rather than pass one promise to the callback and one via `willCallUpdateCallback`? Not sure we'll come up with something that feels less broiler-platey than what we have. -- GitHub Notification of comment by noamr Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/9314#issuecomment-1712507991 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Saturday, 9 September 2023 13:08:27 UTC