Re: [csswg-drafts] [css-color] Add a function to allow authors to specify colors reacting to `color-scheme` (#7561)

Just saw this from @bramus's post, and I suspect that things are already closed / there's no changing things now, but I see this as an approach that doesn't actually solve for the issues people are facing with theming, and does so in a way that will create a trap for them when pursuing proper theming support. 

As a very simple example, what happens when a site that uses this grows to the point where they need to add a high contrast mode? At that point this will require a refactor. 

The other element I'm concerned with here is it all but seals the deal that `color-scheme` will never grow beyond light|dark, despite custom identifiers being allowed for that field. What I'd much prefer is a solution that scales, rather than something that only helps one specific use case. 

As a simple example, consider if it were implemented this way instead: 

```
:root {
  color-scheme: light dark high-contrast;
}

body {
  background: scheme(light #eee, dark #333, high-contrast #fff);
}
```

With this model, you have something that scales beyond light and dark, but now supports visual accessibility modes such has high contrast/colorblind modes. You could also support multiple brands with this, i.e. 

```
:root {
  color-scheme: docs spreadsheets slides;
}

body {
  color: scheme(docs blue, spreadsheets green, slides yellow);
}
```

We shouldn't ship single-purpose tools for the browser, but rather ones that scale and we can build upon. 

-- 
GitHub Notification of comment by jjcm
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/7561#issuecomment-1754069460 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Monday, 9 October 2023 23:49:31 UTC