- From: Sofya Povarova via GitHub <sysbot+gh@w3.org>
- Date: Tue, 28 Nov 2023 22:28:10 +0000
- To: public-css-archive@w3.org
Indeed, you're right. Thank you for pointing that out. It seems that '%' should not be included in the definition of \<dimension-unit\>, as it is currently [done here](https://drafts.csswg.org/css-values-5/#typedef-dimension-unit) and should be: `<dimension-unit> = <length-unit> | <angle-unit> | <time-unit> | <frequency-unit> | <flex-unit>` \<dimension-unit\> is used only for \<attr-type\> which can be '%'. Therefore, \<attr-type\> should be fixed too, '%' should be added to \<attr-type\>: `<attr-type> = string | url | ident | color | number | percentage | length | angle | time | frequency | flex | % | <dimension-unit>` I agree, variable unit is definitely important but it feels like handling that might be a whole separate task. Just to note, I'm relatively new to reading and fixing specifications, there's a chance I might miss something simple. Could it be that this section in the specification is quite recent, and it is better to hold off on creating an issue for it at this point? -- GitHub Notification of comment by SofyaPovarova Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/9648#issuecomment-1830859781 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Tuesday, 28 November 2023 22:28:12 UTC