Re: [csswg-drafts] [css-backgrounds-4][css-values-4] Align logical values for <position> with the ones defined in CSS Logical Properties (#549)

> I think it would help to give the data types more expressive names like `<position-one-axis>`, `<position-two-axes>`, `<position-two-axes-with-offsets>`, and `<position-two-axes-with-one-offset>`, or so.

I think there's a readability balance to be had between splitting things up and abstracting them vs writing them inline, and I think the production structure in Tab's grammar finds a good balance. It's also perfectly suited to hooking together the bg-position and position grammars.

> Was there a reason not to allow combinations of logical keywords and <length-percentage>?

See the `<position-four>` grammar.

> So, for example, for a value of 10% y-start, the origin for the percentage is then interpreted as x-start value.

I think this is a bit too much magic, since if I replace `y-start` with `center`, the interpretation of 10% flips from `x-start` to `left`. That's a great way to introduce errors.

-- 
GitHub Notification of comment by fantasai
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/549#issuecomment-1830301559 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Tuesday, 28 November 2023 17:00:23 UTC