Re: [csswg-drafts] [css-values-4] Simplification algorithm should possibly return single child for min/max (#9559)

> Should it not return the child in this case? I belive an earlier version of the spec did the same as the step for Sum nodes:

Note that removing a Sum node does not change the functional structure of the value; it just means that you don't have a silly `Sum(5px)` tree that just serializes to `calc(5px)` anyway. The same is not true of simplifying away other functions; that changes what the result looks like - `Sum(5px + Min(10px))` serializes to `calc(5px + min(10px))`, rather than `calc(15px)` as if would if you removed the Min node.

But it does appear that browsers do exactly that simplification now, so I'm fine with making it.

(And I'm not really sure why I removed the Min/Max simplification in <https://github.com/w3c/csswg-drafts/commit/56fb59809e43220bb42f626d2a9e066a2172d33c#diff-fc1c32de78d227c8f0c8008469824444d1ba7f027e48a336125017d40b8f6f6fL4283>; the minutes in <https://github.com/w3c/csswg-drafts/issues/4399> don't suggest we stop doing that.)

-- 
GitHub Notification of comment by tabatkins
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/9559#issuecomment-1819720762 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Monday, 20 November 2023 20:03:41 UTC