- From: mind-bending-forks via GitHub <sysbot+gh@w3.org>
- Date: Fri, 10 Nov 2023 11:32:22 +0000
- To: public-css-archive@w3.org
Hi @tabatkins. Apologies for having gone quiet on this issue back in 2020. At the time, I was hoping to assist with finding a resolution but I found myself getting drowned by emerging personal and work matters and this is one of the things that I had to temporarily stop pursuing. Thank you for alerting me to the CSSWG draft of the CSS Values and Units Module Level 4. I have reviewed my initial submission and associated supported document, to remind myself what I perceived the issues and potential solutions to be. I have also read the CSSWG draft text section on the new support for large, small and dynamic viewport units. I have also created `dhv` equivalents of the `vh` problematic examples I originally used, so see what impact that has: Example 1: - Original `vh` version: https://mind-bending-forks.github.io/css-viewport-percentage-length-units/examples/100vh.html - New `dvh` version: https://mind-bending-forks.github.io/css-viewport-percentage-length-units/examples/100dvh.html Example 2: - Original `vh` version: https://mind-bending-forks.github.io/css-viewport-percentage-length-units/examples/100vh-2.html - New `dvh` version: https://mind-bending-forks.github.io/css-viewport-percentage-length-units/examples/100dvh-2.html Example 3: - Original `vh` version: https://mind-bending-forks.github.io/css-viewport-percentage-length-units/examples/holy-grail.html - New `dvh` version: https://mind-bending-forks.github.io/css-viewport-percentage-length-units/examples/holy-grail-dvh.html In terms of what's written, the new units do indeed appear to deal with the issue I raised here! In terms of the examples, I wasn't fully able to test this, in the sense of observing dynamic behaviour when the address bar disappears using `dvh` units. That's because on Firefox and Chrome on Android, the address bar becomes permanent for the `dvh` examples above (whereas, for the original `vh` examples, it is temporary and gets out of the way when at full scroll). No amount of scrolling would cause the address bar to be hidden for me. These are valid browser-specific implementation decisions though. The key thing is that the content is not unexpectedly or irretrievably truncated in those examples now (and that if the address bar were to become hidden, the content should adapt appropriately.) So, I'm happy for this issue to be closed off now. Thank you! -- GitHub Notification of comment by mind-bending-forks Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/5777#issuecomment-1805569191 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Friday, 10 November 2023 11:32:24 UTC