Re: [csswg-drafts] [css-syntax] Review requested of new Parsing text (#8834)

@cdoublev Please don't delete your comments, it's very confusing reading an email, coming here to answer the questions, and finding there's no comment anymore.

Restoring the comment:

> In examples 12 and 13, I do not understand why `@keyframes` is not defined with `<qualified-rule-list>`, and why @page is defined with `<declaration-rule-list>` (in which at-rules - like margin rules - are automatically invalid).

Ah, it's because I'm dumb. `@keyframes` definitely should be `<qualified-rule-list>`, and I misdefined `<declaration-rule-list>` - it should allow declarations and at-rules, and disallow qualified rules. Both fixed now.

> I am not sure what type of item represents `<block-contents>` and its specific sub-productions: is it a `<simple-block>` (ie. a component) or an undefined structure (containing declarations and/or rules)? The return value of consume a block's contents is a bit handwavey. But this may be intentional...

The return value isn't at all handwavey - it's a list of declarations and a list of rules. `<block-contents>` represents the contents of a block; it is not the block itself (it doesn't represent the wrapping `{}`). These productions aren't substantially different from what was there before, I just reshuffled them a little bit.

-- 
GitHub Notification of comment by tabatkins
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/8834#issuecomment-1553546316 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Thursday, 18 May 2023 19:33:15 UTC