- From: Brian Birtles via GitHub <sysbot+gh@w3.org>
- Date: Mon, 12 Jun 2023 23:40:28 +0000
- To: public-css-archive@w3.org
Looks amazing! Thank you so much! I looked over all the changes and they all look great. I tried to build it locally, however, and got a few errors: ``` /home/birtles/.local/lib/python3.10/site-packages/html5lib/_ihatexml.py:266: DataLossWarning: Coercing non-XML name: dfnlt="setkeyframes(keyframes)" warnings.warn("Coercing non-XML name: %s" % name, DataLossWarning) WARNING: The following <var>s were only used once in the document: 'timeline', in algorithm 'animation time to origin-relative time' If these are not typos, please add an ignore='' attribute to the <var>. LINK ERROR: No 'dfn' refs found for 'active time space'. [=active time space=] LINE ~3075: No 'dfn' refs found for 'document time space'. [=document time space=] LINE ~5184: No 'dfn' refs found for 'iteration index'. [=iteration index=] ``` Any chance you can look into these? For example, I think these edits assumed that "active time space" was a definition when it was simply a quasi-reference to an earlier paragraph. -- GitHub Notification of comment by birtles Please view or discuss this issue at https://github.com/w3c/csswg-drafts/pull/8951#issuecomment-1588252511 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Monday, 12 June 2023 23:40:30 UTC