Re: [csswg-drafts] [css-syntax] Review requested of new Parsing text (#8834)

The CSS Working Group just discussed `[css-syntax] Review requested of new Parsing text`, and agreed to the following:

* `RESOLVED: Accept parsing behavior change as described in issue`
* `RESOLVED: Republish CSS Syntax as CRD`

<details><summary>The full IRC log of that discussion</summary>
&lt;florian> TabAtkins: as part of refactorings for nesting, I realized that there is some common structures we could use to make more sense<br>
&lt;florian> TabAtkins: this results into 1 non editorial change<br>
&lt;fantasai> scribe+<br>
&lt;fantasai> TabAtkins: Rules that previously only contained rules, like @media, previously used an lagorithm that only cared about rules, not declarations<br>
&lt;fantasai> TabAtkins: now that they do care about declarations, at least in nested form -- ideally top-level form parses the same way -- and that causes an error-recovery change<br>
&lt;TabAtkins> @media { garbage; bar {...} }<br>
&lt;fantasai> TabAtkins: specifically ...<br>
&lt;fantasai> TabAtkins: this ^ previously would have resulted in a single rule, "garbage; bar { ... }"<br>
&lt;fantasai> TabAtkins: now it results in two statements, a "garbage;" statement and a "bar { ... }" statement<br>
&lt;fantasai> TabAtkins: only affects when there's a semicolon<br>
&lt;florian> q+<br>
&lt;fantasai> TabAtkins: but changes parsing on existing stylesheets<br>
&lt;emilio> q+<br>
&lt;fantasai> TabAtkins: question is if that's OK<br>
&lt;emilio> ack hober<br>
&lt;Rossen_> ack florian<br>
&lt;fantasai> florian: So you say previously we wouldn't discard "garbage;" and keep "bar { ... }"<br>
&lt;fantasai> florian: that seems better, but is it Web-compatible?<br>
&lt;fantasai> TabAtkins: Suspect so, since only small cases<br>
&lt;fantasai> florian: Doesn't seem unliely ppl will put in a media query and forgot selector and then add full rules with a selector later, and the garbage which used to gobble up next rule and thereby disabled it<br>
&lt;fantasai> florian: nolonger disables it<br>
&lt;fantasai> florian: seems plausible that it could be written by accident<br>
&lt;fantasai> florian: Let's try, but it would be possible it causes problems<br>
&lt;Rossen_> ack emilio<br>
&lt;fantasai> emilio: Fact that nested and unnested parse differently seems super weird, so +1 to try fixing this<br>
&lt;fantasai> emilio: I *think* that's how I implemented in Firefox, but might have been conservative when implementing, don't remember<br>
&lt;fantasai> Rossen_: Hearing support, any reasons to not resolve?<br>
&lt;fantasai> RESOLVED: Accept parsing behavior change as described in issue<br>
&lt;fantasai> TabAtkins: can I republish Syntax?<br>
&lt;fantasai> TabAtkins: all the changes should be captured in Changes list; will double-check before publishing<br>
&lt;fantasai> TabAtkins: still need to do review of tests that might need changing, but that's separate<br>
&lt;fantasai> Rossen_: Any objections to new CR?<br>
&lt;fantasai> RESOLVED: Republish CSS Syntax as CRD<br>
</details>


-- 
GitHub Notification of comment by css-meeting-bot
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/8834#issuecomment-1646230236 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Friday, 21 July 2023 20:55:54 UTC