- From: Tab Atkins Jr. via GitHub <sysbot+gh@w3.org>
- Date: Wed, 05 Jul 2023 22:44:22 +0000
- To: public-css-archive@w3.org
> (aka I'll make a closer copy of CSSKeyframesRule). Nah CSSKeyframesRule has a *weird* set of operations. This is why I'm suggested CSSGroupingRule instead. > I think inheritance from CSSGroupingRule is more appropriate if the child rules can be of any type. > > If only one type of child rules are allowed, then it should inherit from CSSRule (again using CSSKeyframesRule as an example). Nothing about CSSGroupingRule suggests it's specifically for multiple child rule types. The "insert a rule" operation checks if the rule type is allowed in that context. If they'd been created in the opposite order, we've have CSSKeyframesRule inherit from CSSGroupingRule rather than use some weird bespoke operations. -- GitHub Notification of comment by tabatkins Please view or discuss this issue at https://github.com/w3c/csswg-drafts/pull/9005#issuecomment-1622628605 using your GitHub account -- Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Wednesday, 5 July 2023 22:44:23 UTC