Re: [csswg-drafts] [css-view-transitions-1] domUpdated isn't the right term (#8144)

The CSS Working Group just discussed `[css-view-transitions-1] domUpdated isn't the right term`, and agreed to the following:

* ``RESOLVED: adopt suggested change to rename to `updateCallbackDone``

<details><summary>The full IRC log of that discussion</summary>
&lt;JakeA> View transitions wraps a state change - we attempt generate a transition from that state change<br>
&lt;JakeA> The developer provides a callback where they do that change, usually by modifying the DOM in some way. It can be async.<br>
&lt;JakeA> Sometimes you just want to know when the state change is complete<br>
&lt;JakeA> We provided a promise for that,`domUpdated`, which fulfills when the promise returned by the callback fulfills<br>
&lt;JakeA> Anne said "we don't really expose DOM as a term to web content", so the name is bad<br>
&lt;JakeA> So, we need a new name<br>
&lt;JakeA> Couple of options: `stateUpdated` - avoids using DOM, but a bit vague, might be confusing due to frameworks use of 'state'.<br>
&lt;JakeA> Vlad suggested that, since the promise resolves along with the callback, we name it `updateCallbackDone`.<br>
&lt;JakeA> I like that, since if the developer does stuff other than DOM updating in the callback, the promise name still makes sense.<br>
&lt;JakeA> Anne is happy with that.<br>
&lt;bramus> JakeA: I can take up this one. posted a bunch of messages above<br>
&lt;TabAtkins> +1 to suggested name change, it's clear and tied directly to what's actually happening, and I think will make sense for an author.<br>
&lt;masonf> `DOMContentLoaded` ?<br>
&lt;bramus> JakeA: I guess we are saying: any objections?<br>
&lt;bramus> astearns: not knowing what the callback is named that seems vague. what is it?<br>
&lt;bramus> JakeA: it does not have an developer visible name. authors pass it in as argument<br>
&lt;bramus> JakeA: `updateCallback` and then `updateCallbackDone`<br>
&lt;florian> have not followed deeply, but seems reasonable<br>
&lt;bramus> TabAtkins: I like it. makes sense and matches spec language<br>
&lt;bramus> bramus: +1<br>
&lt;bramus> astearns: proposed resolution: adopt suggested change to rename to `updateCallbackDone `<br>
&lt;bramus> RESOLVED: adopt suggested change to rename to `updateCallbackDone<br>
</details>


-- 
GitHub Notification of comment by css-meeting-bot
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/8144#issuecomment-1387463625 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Wednesday, 18 January 2023 17:39:11 UTC