Re: [csswg-drafts] [mediaqueries] Merge error handling section into evaluating section (#7595)

> I now recall that I specifically carried over the "not all" behavior for things that resolve to unknown because that's what previous UAs would do to such MQs.

The tests currently seem to use serialising `not all` as a test for "media query could be parsed", after @andruud's changes back in May (which match his implementation in Chrome), i.e., only expecting `not all` for:

> A media query that does not match the grammar in the previous section must be replaced by not all during parsing.

For example, the tests assert that `@media screen, (max-width) {}` must serialise as `@media screen, (max-width) {}`.

So it seems like Chrome doesn't implement that serialising behaviour now? And it sounded on the call like @emilio was reasonably questioning whether we want to rewrite it on serialisation rather than propagating the unknown media query to the output (which to me sounds like the sensible thing to do), and if [Chrome is currently shipping](https://wpt.fyi/results/css/mediaqueries/test_media_queries.html?run_id=5204232962048000&run_id=5102686010081280&run_id=5161370832601088) then I guess we have the evidence it's web compatible. 

> However, I suspect that the "unknown media type" still needs to serialize to "not all", as that's likely the most common way we're exposing this behavior today.

We don't seem to have tests for that, at least.

-- 
GitHub Notification of comment by gsnedders
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/7595#issuecomment-1284732180 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Thursday, 20 October 2022 00:23:09 UTC