Re: [csswg-drafts] [css-grid-2] How to properly accommodate margin/border/padding of a subgrid with no item on the edges (#7465)

The CSS Working Group just discussed `[css-grid-2] How to properly accommodate margin/border/padding of a subgrid with no item on the edges`, and agreed to the following:

* `RESOLVED: Change the spec to simplify this sizing and figure out what tests we need`

<details><summary>The full IRC log of that discussion</summary>
&lt;dael> Topic: [css-grid-2] How to properly accommodate margin/border/padding of a subgrid with no item on the edges<br>
&lt;dael> github: https://github.com/w3c/csswg-drafts/issues/7465#issuecomment-1265913276<br>
&lt;dael> astearns: Can you take fantasai?<br>
&lt;dael> fantasai: Yep. The subgrids layout we have a bunch of rules for laying out stuff within a subgrid as part of parent<br>
&lt;dael> fantasai: We figure out which col and rows items in subgrid assigned to and layout as if in parent<br>
&lt;dael> fantasai: Difference is how we handle margins and padding. Figure out total amount of margin padding border for items at edge of subgrid and add as magic margin to inflate auto-sized<br>
&lt;dael> fantasai: When you layout in grid takes into account extra margin and padding I should stay away from<br>
&lt;dael> fantasai: in order to do that accurately we have a bunch of rules to insert hypothetical items at edge of subgrid to make sure even if it's empty it's sized<br>
&lt;dael> fantasai: Spec rules and browser impl are different. We had a complex rule to inster item with span of one then with span of two and however many we need to cover the spans and make sure there's enough space<br>
&lt;dael> fantasai: Problem is that it creates a bunch of space and whne you put items down ones in second column don't have magic margin. Doesn't work out to match up in that way<br>
&lt;dael> fantasai: Browsers don't do complex spanning. Only put items in first and last track. If you have fixed width 20px first track and second is auto and subgrid has 40px of padding the padding crosses into second track and items don't know about it.<br>
&lt;dael> fantasai: If we wanted to figure that out it's quite complicated to figure out the margin you want to add. None of the browsers are doing it and not sure it's necessary to do the complex thing<br>
&lt;dael> fantasai: Question for WG is do we simplify spec down to only look at first and last or investigate what we can do to try and make it work for inner tracks?<br>
&lt;dael> fantasai: Our suggestion is simplify down and see what happens, but open for questions and comments<br>
&lt;dael> astearns: Test cases we removed because missing spec text. Would those become valid?<br>
&lt;dael> fantasai: Don't know. I think whatever we do we'll want the test cases but maybe different references<br>
&lt;mattwoodrow_> q+<br>
&lt;dael> iank_: I support removing hypotetical item concept. I believe MS folks studied this and super hard to get correct<br>
&lt;astearns> ack mattwoodrow_<br>
&lt;dael> mattwoodrow_: Also support simplifying it. I spent a bit of time trying to figure out how to impl and very complex when you nest grids<br>
&lt;dael> fantasai: Will still need some margin padding added, it's just not leaked to multiple tracks<br>
&lt;dael> astearns: Is there interop in browsers? Or are we coming up with something that might need bug fixes?<br>
&lt;dael> iank_: From what I've seen broadly speaking subgrid is lightly tested in some areas so wouldn't shock if there are subtle differences between browsers<br>
&lt;dael> fantasai: Either way should make sure have enough tests. Might be some bug fixes but closer to interop on simplified version<br>
&lt;dael> astearns: Prop: Change the spec to simplify this sizing and figure out what tests we need<br>
&lt;dael> astearns: Obj?<br>
&lt;dael> RESOLVED: Change the spec to simplify this sizing and figure out what tests we need<br>
</details>


-- 
GitHub Notification of comment by css-meeting-bot
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/7465#issuecomment-1301484688 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Wednesday, 2 November 2022 23:22:17 UTC