Re: [csswg-drafts] [web-animations-1][css-animations-2] Bug in handling of auto-rewind state when playing new CSS animations (#7145)

> > I believe @BorisChiou looked into WebKit and found something similar.
> 
> WebKit runs the _play an animation_ procedure with the _auto-rewind_ set to true when it first plays and when it's resumed.

I think if it were using _auto-rewind_ set to **true** for _resuming_, it would fail the following test:

https://hg.mozilla.org/try/rev/73cd7556994f45c2731b973f3e49c874fd77c4a3#l2.3

but I believe when Boris checked it didn't fail that.

> @birtles Do you have some WPT coverage to show some examples that would have previously failed (according to the spec that is)?

There are a couple of tests in https://hg.mozilla.org/try/rev/73cd7556994f45c2731b973f3e49c874fd77c4a3 but to some extent the changes overlap.

The problem with auto-rewind handling being broken means that if any browser actually implemented both CSS Animations and Web Animations per spec, no CSS animation would ever start. In that sense, every CSS animation test covers this.

I thought we could add a test that demonstrates that calling `updatePlaybackRate(0)` vs `updatePlaybackRate(-1)` now behaves consistently, but I believe that difference only every manifested when `currentTime` was unresolved and now we handle that case specifically which is covered by: https://hg.mozilla.org/try/rev/73cd7556994f45c2731b973f3e49c874fd77c4a3#l3.12

-- 
GitHub Notification of comment by birtles
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/7145#issuecomment-1072914512 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Saturday, 19 March 2022 01:39:40 UTC