Re: [csswg-drafts] [css-flexbox-1] Intrinsic Main Size algo has errors (#7189)

The CSS Working Group just discussed `[css-flexbox-1] Intrinsic Main Size algo has errors`.

<details><summary>The full IRC log of that discussion</summary>
&lt;dael> Topic: [css-flexbox-1] Intrinsic Main Size algo has errors<br>
&lt;fantasai> See https://github.com/w3c/csswg-drafts/issues/7189#issuecomment-1172771501<br>
&lt;dael> github: https://github.com/w3c/csswg-drafts/issues/7189<br>
&lt;dael> TabAtkins: This is a call for review from others. We found when reviewing WPT that the handling of intrinsic sizes of flexboex when sum &lt; 1 wasn't correct. Have gone back and forth with dgrogan a few times. Pretty sure it's right now.<br>
&lt;dael> TabAtkins: Found to avoid explosions to infinity need slightly different algo to get correct intrinsic size. David thinks they're fine. Anyone else, we would appriciate review. It's is subtle changes and if there are mistakes or violates other requirements would appreciate review<br>
&lt;dael> fantasai: We should get resolution, but can have more time for review<br>
&lt;dael> Rossen_: I was reading through commit linked in issue and it's quite involved. Would prefer to give time to reason through it<br>
&lt;dael> Rossen_: I think even though some of it is notes they're complex and good to give time<br>
&lt;dael> TabAtkins: Yeah. This was complicated enough I had to do 2 nested details. Definitely a little complex<br>
&lt;dael> Rossen_: So in that case action to implementors of flexbox to please review the commit<br>
&lt;Rossen_> commit to be reviewed https://github.com/w3c/csswg-drafts/commit/d452a10a921391dc6b6a96e7be97218692c1de53<br>
&lt;Rossen_> q?<br>
&lt;dael> jensimmons: Do the WPT tests need updating or are they now accurate?<br>
&lt;dael> TabAtkins: Not 100% sure but I believe tests will need updating. I think David will take care of that<br>
&lt;dael> jensimmons: If he's not, recommend opening an issue on interop repo<br>
&lt;dael> jensimmons: Just so they're aware<br>
&lt;dael> jensimmons: I can file<br>
&lt;dael> fantasai: I think intrinsic algo is a focus on there since it's been changing based on impl feedback<br>
&lt;dael> Rossen_: Would be great to add the issue, thanks jensimmons<br>
</details>


-- 
GitHub Notification of comment by css-meeting-bot
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/7189#issuecomment-1176869105 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Thursday, 7 July 2022 00:00:11 UTC