Re: [csswg-drafts] [css-color-4] Gamut Mapping Algorithm and Color Banding (#7135)

> but `E - JND (< 0) < ε` is always true.

It is indeed, oops.

> (May be a typo of "`if (JND - E < ε)`" ?)

Yes. Which, once corrected, reveals the second bug in the code I posted above; almost always, the clipped value is returned but sometimes, `while (max - min > ε)` becomes false and then we ... unceremoniously drop off the end without returning a result (/facepalm).

> It's likely that this would cause the algorithm to kick out too fast.

It did; the speedup advantage has now reduced, but it is still 2-3x faster than color.js current (OKLCH chroma, deltaE2000).

-- 
GitHub Notification of comment by svgeesus
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/7135#issuecomment-1175086698 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Tuesday, 5 July 2022 13:52:05 UTC