Re: [csswg-drafts] [css-flexbox-1] Intrinsic Main Size algo has errors (#7189)

Thanks for working on this.

Two things:

1. I think min/max main sizes need to be reapplied after multi-line containers cap/floor the contribution by flex base size for non-growable/shrinkable items.

2. This change removing the floors introduces divide-by-zero operations, which are undefined, when grow/shrink factors are 0.

```diff
@@ -2903,38 +2903,52 @@ Flex Container Intrinsic Main Sizes</h4>
    For each <a>flex item</a>,
    subtract its outer <a>flex base size</a> from its [[#intrinsic-item-contributions|max-content contribution]] size.
    If that result is positive,
-   divide by its <a>flex grow factor</a> floored at 1;
+   divide by its <a>flex grow factor</a>;
    if negative,
-   divide by its <a>scaled flex shrink factor</a>
-   having floored the <a>flex shrink factor</a> at 1.
-   This is the item's <var>max-content flex fraction</var>.
+   divide by its <a>scaled flex shrink factor</a>.
+   This is the item's <var>desired flex fraction</var>.
```

-- 
GitHub Notification of comment by davidsgrogan
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/7189#issuecomment-1086460321 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Saturday, 2 April 2022 01:29:55 UTC