Re: [csswg-drafts] [css-lists] Algorithm for initial counter value in reversed list should repeat the last increment instead of the 1st one (#6797)

I'm in favor of this change. I think it makes slightly more sense to use the last (non-zero) increment than the first.
The last algo above looks good to me. I tested the last two examples in a local build which implements this, and I get the results as indicated in the comments.

FYI, I'm correcting the existing tests (as if the proposal here is adopted) and adding a ton of new WPTs in:
https://phabricator.services.mozilla.com/D129958

Here's the paths to the new tests in case you want to reference them in the spec:
/css/css-lists/foo-counter-reversed-006a.html
/css/css-lists/foo-counter-reversed-006b.html
/css/css-lists/foo-counter-reversed-006c.html
/css/css-lists/foo-counter-reversed-006d.html
/css/css-lists/foo-counter-reversed-006e.html
/css/css-lists/foo-counter-reversed-007a.html
/css/css-lists/foo-counter-reversed-007b.html
/css/css-lists/foo-counter-reversed-008a.html
/css/css-lists/foo-counter-reversed-008b.html
/css/css-lists/foo-counter-reversed-009a.html
/css/css-lists/foo-counter-reversed-009b.html
/css/css-lists/li-value-reversed-006a.html
/css/css-lists/li-value-reversed-006b.html
/css/css-lists/li-value-reversed-006c.html
/css/css-lists/li-value-reversed-006d.html
/css/css-lists/li-value-reversed-006e.html
/css/css-lists/li-value-reversed-007a.html
/css/css-lists/li-value-reversed-007b.html
/css/css-lists/li-value-reversed-008a.html
/css/css-lists/li-value-reversed-008b.html
/css/css-lists/li-value-reversed-009a.html
/css/css-lists/li-value-reversed-009b.html

I'm also amending these tests to check the syntax:
/css/css-lists/parsing/counter-increment-invalid.html
/css/css-lists/parsing/counter-reset-invalid.html
/css/css-lists/parsing/counter-reset-valid.html
/css/css-lists/parsing/counter-set-invalid.html

I'll wait for a resolution before landing that...


-- 
GitHub Notification of comment by MatsPalmgren
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/6797#issuecomment-961502277 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Thursday, 4 November 2021 23:14:57 UTC