W3C home > Mailing lists > Public > public-css-archive@w3.org > May 2021

Re: [csswg-drafts] [css-counter-styles] Additive algorithm shouldn't divide by 0 (#5784)

From: Oriol Brufau via GitHub <sysbot+gh@w3.org>
Date: Fri, 14 May 2021 18:51:35 +0000
To: public-css-archive@w3.org
Message-ID: <issue_comment.created-841435887-1621018293-sysbot+gh@w3.org>
I guess you can remove the "or weight is greater than value" condition. If `weight > value`, then `reps = 0`, so `S` and `value` are not actually altered anyways. And the algorithm returns at 3.5, avoiding the assert.

-- 
GitHub Notification of comment by Loirooriol
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/5784#issuecomment-841435887 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Friday, 14 May 2021 18:51:37 UTC

This archive was generated by hypermail 2.4.0 : Tuesday, 5 July 2022 06:42:33 UTC