Re: [csswg-drafts] [css-fonts-5] advance-override details (#5983)

A couple points:

> I think there should be a separate font-size-override that can apply a scale factor to the used font size; I suspect this would often be the better tool to use.

Agreed, and I'd go further: I think shipping `advance-override` without shipping `font-size-override` would be harmful. Because advance-override breaks a lot of writing systems and can create weird rhythms in the text that are likely to impact readability/accessibility, and font-size-override wouldn't have those problems. In any situation were font-size-override would be adequate, it should be used instead of advance-override.

> I think I'd lean towards either the first (separate width/height descriptors) or the third (second param defaults to normal, so no height override unless explicitly given), as most authors won't be thinking about vertical layout at all unless it's their primary focus, and there's little reason to expect that the same amount of override will make sense for both axes.

Agreed. I'd probably go with the third option, seems the friendliest syntactically.

>>>    How is spacing added to each character?
>>  Proposal: spacing is added after each character, for the reasons I gave in #5983 (comment) for reasons.
> Disagree; I think spacing should be added equally on both sides of each glyph. [[ rationale ]](https://github.com/w3c/csswg-drafts/issues/5983#issuecomment-788776441)

Agree with jfkthame's rationale. Yes, adding it just to the right side works best for left-aligned paragraphs. But not all affected content is left-aligned.

> I think my counter-proposal to the above discussion would be: "intentionally don't innovate here, and make it behave exactly like letter-spacing

Note that letter-spacing adds a constant per typographic character unit. Advance-override is defined to scale the advance of each glyph proportionally. Also it's being defined as a font metric override, not a text layout feature...


-- 
GitHub Notification of comment by fantasai
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/5983#issuecomment-789898142 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Wednesday, 3 March 2021 17:12:36 UTC