Re: [csswg-drafts] [css-values-4] initial work on vhc unit proposal text. Resolves #4329 (#5108) from Anthony Frehner via GitHub on 2021-06-18 (public-css-archive@w3.org from June 2021)

From: Anthony Frehner via GitHub <sysbot+gh@w3.org>
Date: Fri, 18 Jun 2021 02:14:27 +0000
To: public-css-archive@w3.org
Message-ID: <issue_comment.created-863703283-1623982465-sysbot+gh@w3.org>

> Hi @frehner ! @tabatkins and I committed [0f78ba4](https://github.com/w3c/csswg-drafts/commit/0f78ba4ee462bf3ea879a122789dc153780b88f6) as a replacement of this PR. Not that there was anything specifically wrong with yours, it was a good set of edits! But we needed a lot more detail in the spec, and also a bit of restructuring seemed necessary, so I'm going to close out this PR without accepting. We did add your name to the Acknowledgements section, though, to say thanks for your efforts on this issue. ;) You did a great job of channeling the discussion and helping to make this happen. <3

Thank you both so much; I’m excited to see progress, and honestly it it makes me a little giddy to see my name in there as well. 😃 

-- 
GitHub Notification of comment by frehner
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/pull/5108#issuecomment-863703283 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Friday, 18 June 2021 02:14:45 UTC