- From: Tab Atkins Jr. via GitHub <sysbot+gh@w3.org>
- Date: Thu, 10 Jun 2021 17:49:19 +0000
- To: public-css-archive@w3.org
Reviewing the use-counter code:
> ```cpp
> if (IsMultiline() && !line_contexts.IsEmpty()) {
> UseCounter::Count(GetDocument(),
> WebFeature::kFlexboxSingleLineAlignContent);
> }
> ```
Unless I'm completely mistaken, this is counting the exact wrong thing - it appears to be incrementing the use-counter whenever there's a *multi-line* flexbox with significant alignment. (start alignment has already bailed out before these lines, as it doesn't have a significant effect.) It looks like it just took the existing early-exit test (`line_contexts.IsEmpty() || !IsMultiline()`) and negated it.
So unfortunately, the use counter data appears to be entirely worthless for our purpose. :(
--
GitHub Notification of comment by tabatkins
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/3052#issuecomment-858836426 using your GitHub account
--
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Thursday, 10 June 2021 17:50:30 UTC