Re: [csswg-drafts] [css-fonts-4] font-display says it's valid in @font-feature-values but it isn't an at-rule (#2973)

Sooo this long-reported bug is still open. As of today [the spec says](https://drafts.csswg.org/css-fonts-4/#font-feature-values-syntax):

```css
@font-feature-values <family-name># { <rule-list> }

<feature-value-block> = <font-feature-value-type> { <declaration-list> }

<font-feature-value-type> = @stylistic | @historical-forms | @styleset | @character-variant
  | @swash | @ornaments | @annotation
```

which means that the [font-display descriptor for `@font-feature-values`](https://drafts.csswg.org/css-fonts-4/#font-display-font-feature-values) can't actually be used thee. (The same descriptor can, of course, be used [in `@font-face`](https://drafts.csswg.org/css-fonts-4/#font-display-desc).

To fix this, 


```css
@font-feature-values <family-name># { <rule-list> }

<feature-value-block> = <font-feature-value-type> { <declaration-list> } |  font-display

<font-feature-value-type> = @stylistic | @historical-forms | @styleset | @character-variant
  | @swash | @ornaments | @annotation
```

but also, 

> An `@font-feature-values` rule’s prelude contains a list of font family names, followed by a block containing multiple `<feature-value-block>`s, a special type of subsidiary at-rule. Each `<feature-value-block>` contains declarations mapping author-chosen human-friendly names (such as "flowing") to feature indexes for the associated feature.

to

> An `@font-feature-values` rule’s prelude contains a list of font family names, followed by a block containing zero or more optional multiple `<feature-value-block>`s, (a special type of subsidiary at-rule) and an optional `font-display` descriptor

> Each `<feature-value-block>` contains declarations mapping author-chosen human-friendly names (such as "flowing") to feature indexes for the associated feature.

Right? Plus some examples, like the one @lilles posted

@rsheeter @litherum sound good?

-- 
GitHub Notification of comment by svgeesus
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/2973#issuecomment-886876326 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Monday, 26 July 2021 17:08:11 UTC