Re: [csswg-drafts] [web-animations-1] Add steps for transitioning to/from a scroll timeline. (#5423)

Updated the Blink CL: https://chromium-review.googlesource.com/c/chromium/src/+/2324101 with the following rules:

* when setting a scroll timeline
   * if play state was playing or finished
      * set start time to 0 or effect end
  * if play state was paused
     * set current time to previous current time (this is to avoid a jump with a pause-pending animation with a start time
and a pending pause microtask).
    * set a flag to reset current time on resuming the animation.
* when transition from a scroll timeline to a document timeline
    * set current time to previous current time

* when playing an animation
   * if the flag to reset current time on resume is set
      * set current time to unresolved
      * set clear flag to false.

This implementation is very close to option 4 outlined above and should address the concerns with animation jumps during pause.  No change in existing WPTs.  I could be convinced either way on preserving current time when transitioning from a scroll timeline to a document timeline; however, I believe having this rule would better align with user expectations.  

@ogerchikov please take a look at the CL (particularly setting-timeline.tentative.html) and let me know what you think.


-- 
GitHub Notification of comment by kevers-google
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/pull/5423#issuecomment-684912491 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Tuesday, 1 September 2020 14:51:53 UTC