Re: [csswg-drafts] [css-grid-1] Fix aspect-ratio errors in css-grid-1 (#5615)

The CSS Working Group just discussed `Fix aspect-ratio errors in css-grid-1`, and agreed to the following:

* `RESOLVED: accept aspect-ratio error changes in css-grid-1`

<details><summary>The full IRC log of that discussion</summary>
&lt;heycam> Topic: Fix aspect-ratio errors in css-grid-1<br>
&lt;heycam> github: https://github.com/w3c/csswg-drafts/issues/5615<br>
&lt;heycam> fantasai: there was a commit which attempted to clarify interaction of aspect-ratio and grid item sizing<br>
&lt;heycam> ... that introduced an error, which I fixed<br>
&lt;heycam> ... I'd like to verify the fix with the WG<br>
&lt;heycam> ... and republish grid-1 and grid-2 with the correction<br>
&lt;heycam> ... as a CRD<br>
&lt;heycam> Rossen_: is there a commit diff we should be looking at?<br>
&lt;heycam> ... or just that PR that you linked there<br>
&lt;fantasai> https://drafts.csswg.org/css-grid-1/#grid-item-sizing<br>
&lt;heycam> fantasai: commit I linked, that shows the fix to the problem, but the resulting text needs to be reviewed<br>
&lt;Rossen_> q?<br>
&lt;heycam> Rossen_: we resolved for this change that will be different from flexbox, right?<br>
&lt;heycam> fantasai: this one wasn't supposed to be a change, just a clarification<br>
&lt;heycam> ... can grab a diff against the older version<br>
&lt;fantasai> https://services.w3.org/htmldiff?doc1=https%3A%2F%2Fwww.w3.org%2FTR%2F2017%2FCR-css-grid-1-20171214%2F&amp;doc2=https%3A%2F%2Fdrafts.csswg.org%2Fcss-grid-1%2F#grid-item-sizing<br>
&lt;fantasai> https://github.com/w3c/csswg-drafts/commit/ee91993c92ba7d119a6b89c64667094511d67272<br>
&lt;chris> rrsagent, here<br>
&lt;RRSAgent> See https://www.w3.org/2020/10/19-css-irc#T20-30-55<br>
&lt;chris> rrsagent, make minutes<br>
&lt;RRSAgent> I have made the request to generate https://www.w3.org/2020/10/19-css-minutes.html chris<br>
&lt;heycam> Rossen_: any comments or objections to accept this diff?<br>
&lt;heycam> oriol: I think it's a good change, because there was a sentence saying that for stretch the rules would be modified to follow aspect-ratio.  but impls were not doing that<br>
&lt;heycam> ... so if you have stretch, aspect-ratio is not taken into account<br>
&lt;heycam> ... so I think removing this sentence is good<br>
&lt;florian> I was hoping oriol had reviewed this. Given that he has, I feel confident it's fine :)<br>
&lt;dbaron> (There was a line attributed to me above that wasn't me, btw.)<br>
&lt;heycam> RESOLVED: accept aspect-ratio error changes in css-grid-1<br>
</details>


-- 
GitHub Notification of comment by css-meeting-bot
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/5615#issuecomment-712425913 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config

Received on Monday, 19 October 2020 20:33:44 UTC