W3C home > Mailing lists > Public > public-css-archive@w3.org > November 2020

Re: [csswg-drafts] [css-grid] Note implies losing an aspect-ratio when it shouldn't? (#5713)

From: Oriol Brufau via GitHub <sysbot+gh@w3.org>
Date: Wed, 11 Nov 2020 01:02:12 +0000
To: public-css-archive@w3.org
Message-ID: <issue_comment.created-725061168-1605056531-sysbot+gh@w3.org>
Regarding consistency with flex, I don't think your testcase is testing the proper thing. The flex item is effectively stretched in the cross axis, it's just that it's not stretched in the main axis because `justify-self` doesn't apply, so the aspect ratio is preserved.

The interesting testcase would be https://software.hixie.ch/utilities/js/live-dom-viewer/saved/8677

In latest Chromium with experimental flags, the grid item and the flex item are identical (`aspect-ratio` has no effect). But if I apply https://chromium-review.googlesource.com/c/chromium/src/+/2526928, they are different:

![master](https://user-images.githubusercontent.com/7477678/98751813-20bf4b80-23c1-11eb-9087-01effa11eea2.png) vs  ![patch](https://user-images.githubusercontent.com/7477678/98751853-32085800-23c1-11eb-9b0a-c3a544d6b023.png)




-- 
GitHub Notification of comment by Loirooriol
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/5713#issuecomment-725061168 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Wednesday, 11 November 2020 01:02:14 UTC

This archive was generated by hypermail 2.4.0 : Tuesday, 5 July 2022 06:42:22 UTC