W3C home > Mailing lists > Public > public-css-archive@w3.org > November 2020

Re: [csswg-drafts] [css-contain-2] Clarify how sizing containment works (#5643)

From: CSS Meeting Bot via GitHub <sysbot+gh@w3.org>
Date: Thu, 05 Nov 2020 00:18:34 +0000
To: public-css-archive@w3.org
Message-ID: <issue_comment.created-722045252-1604535512-sysbot+gh@w3.org>
The CSS Working Group just discussed `[css-contain-2] Clarify how sizing containment works`, and agreed to the following:

* `RESOLVED: Uncomment possibility of an exception and accept the PR`

<details><summary>The full IRC log of that discussion</summary>
&lt;dael> Topic: [css-contain-2] Clarify how sizing containment works<br>
&lt;dael> github: https://github.com/w3c/csswg-drafts/pull/5643<br>
&lt;dael> florian: A while back Mats pointed out the text of size continanment wasn't clear. Phrasing was handwavy. Long discussion in github of how it could be interpreted and which is right.<br>
&lt;dael> florian: Made a PR which clarifies. Reviewed by fantasai and I think TabAtkins. Reasonably confident it's good<br>
&lt;dael> florian: There was a longer dicussion that maybe original intent wasn't right b/c possibility size containment was toward container queries and maybe wanted to ignore things like grid-track-sizing instead of treat grid as empty. That would make it nicer for when element quries are a thing.<br>
&lt;dael> florian: Sep GH about if container queries is possible here<br>
&lt;dael> florian: Could have css contain open a door for possible exceptions in other specs. size as if empty but we apply all properties unless stated otherwise in other specs.<br>
&lt;dael> florian: Specs like grid are further back in rec track so we don't consider it in css contain or we close the door now<br>
&lt;dael> florian: Expect for that I'm confident text is good. DIdn't get review from Mats unfortunately. Hard to read as a diff because a lot of red but there's a link to read<br>
&lt;dael> florian: Would like approval to merge unless comments<br>
&lt;dael> fantasai: contain 1 as well?<br>
&lt;dael> florian: Yes. Editorial compred to intent of spec. Editorial compared to text is debatable. But yes to get into L1<br>
&lt;dael> chrishtr: Does the PR make it any different from browser behavior?<br>
&lt;dael> florian: Nothing interop changes. corner cases about size containement to grid container with sized tracks which are different between FF and Chrome which would change<br>
&lt;dael> chrishtr: Are they ennumeratate?<br>
&lt;dael> florian: I know them and can write them down. I plan to write tests to expose details<br>
&lt;dael> astearns: Not currently any text?<br>
&lt;dael> s/text/test<br>
&lt;dael> florian: Tests that fail in FF and remain valid. Test are for original intent which was not clearly expressed<br>
&lt;dael> florian: Now it's more precise we can write more tests<br>
&lt;dael> astearns: Usually when we have an issue and decide on a fix we close and put needs test cases. Since this is a PR I'm worried someone looking for test cases wouldn't find it to write. I wonder if it would make sense to create an issues for testing where it enumerates the new cases<br>
&lt;dael> florian: I intend to write tests in a day or two of resolution, but I'm okay to have more<br>
&lt;dael> astearns: If that's the case then no need<br>
&lt;dael> astearns: Any other comments?<br>
&lt;dael> heycam: I can ping Mats but don't want to block<br>
&lt;dael> astearns: Prop: Accept the edits and create tests<br>
&lt;dael> florian: With open possibilities for other specs to exempt from the rules or close the door?<br>
&lt;dael> heycam: Always possible for specs to override?<br>
&lt;dael> florian: It's nicer to call it out, but even if we don't you can still do it<br>
&lt;dael> astearns: Since it's not clear we'll go ahead maybe leave it in as a we don't know yet<br>
&lt;dael> astearns: Other opinions?<br>
&lt;dael> astearns: PR has the exceptions can be made?<br>
&lt;dael> florian: Commented out. I need to un-comment<br>
&lt;dael> astearns: Prop: Uncomment possibility of an exception and accept the PR<br>
&lt;dael> astearns: Objections?<br>
&lt;dael> RESOLVED: Uncomment possibility of an exception and accept the PR<br>
&lt;dael> florian: Thank you<br>

GitHub Notification of comment by css-meeting-bot
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/pull/5643#issuecomment-722045252 using your GitHub account

Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Thursday, 5 November 2020 00:18:36 UTC

This archive was generated by hypermail 2.4.0 : Tuesday, 5 July 2022 06:42:22 UTC