Re: [csswg-drafts] [css-grid] Unclear how to limit track growth by fit-content() argument (#4549)

@fantasai OK, so now

 - Non-spanning algorithm has been restored in 4f4fde91831eb51820585aa4b1c29f8b4f4687c8, it's fine now.
 - Spanning algorithm still needs to clamp the growth limits, because https://drafts.csswg.org/css-grid/#extra-space says

    > Distribute space beyond growth limits: If space remains after all tracks are frozen, unfreeze and continue to distribute space to the item-incurred increase of…
    > - when handling any intrinsic growth limit: **all affected tracks**.

    So it doesn't matter that a when `fit-content()` track reaches its limit, it's treated as a fixed function. Because the spec still says "all affected tracks", and the `fit-content()` doesn't stop being an affected track even when it reaches its limit.

    That's why I proposed

    ```diff
    @@ -4265,7 +4265,8 @@ Distributing Extra Space Across Spanned Tracks</h4>
                   if there are no such tracks, then all affected tracks.
                 <li>
                   when handling any intrinsic <a>growth limit</a>:
    -              all affected tracks.
    +              any affected track that happens to also have an intrinsic <a>max track sizing function</a>;
    +              if there are no such tracks, then stop distributing space.
               </ul>
     
               For this purpose, ''fit-content()'' tracks are treated as ''max-content''
    ```

 - The distribution of base sizes is not taking `fit-content()` limits in an optimal way but I'm fine with leaving the improvements for the future.

-- 
GitHub Notification of comment by Loirooriol
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/4549#issuecomment-662772146 using your GitHub account

Received on Thursday, 23 July 2020 01:06:43 UTC