W3C home > Mailing lists > Public > public-css-archive@w3.org > August 2020

Re: [csswg-drafts] [web-animations-1] commitStyles would be more useful / performant if it committed when animation was replaced / finished. (#5475)

From: Robert Flack via GitHub <sysbot+gh@w3.org>
Date: Fri, 28 Aug 2020 14:42:29 +0000
To: public-css-archive@w3.org
Message-ID: <issue_comment.created-682640646-1598625748-sysbot+gh@w3.org>
> I think this might be a dupe of #5394 ?
> 

Thanks, I think this is a duplicate. I should have checked more carefully.

> > If it's not too late, I propose that commitStyles should commit the effect value when the effect is removed (whether by replacement, finishing, or canceling).
> 
> I think that's not what we want? When the fill mode is empty, if the animation finishes, the value of the effect is empty?

My intention was that conceptually value just before the animation was finished is the one that would be committed, such that the effect would not be empty.
> 
> > * have commitStyles commit the last animation value (e.g. the final position before the animation finished).
> 
> I also think that's not what we want since, if I understand the suggestion correctly, it would end up being frame-rate dependent.

The intent is that it would not be frame rate dependent but rather if you assume an infinitely precise timeline it would be the value on that timeline when the effect finished. This would be equivalent to the fill value were it to have a fill.

> > * Add a "commit" fill mode which implicitly commits the animation on completion.
> 
> That's an interesting idea, although I'm a little wary of extending fill modes since they're already problematic enough. It also does feel like a bit of a layering violation. Fill modes just affect the output of the timing model, they shouldn't affect the behavior of the animation (especially once you have nested effects).
> 
> An alternative from #5394 is to add a flag to `commitStyles()` that applies the appropriate fill mode.

Adding a flag to commitStyles seems reasonable, though I have concerns with that specific approach which I will leave in a comment over there.

-- 
GitHub Notification of comment by flackr
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/5475#issuecomment-682640646 using your GitHub account


-- 
Sent via github-notify-ml as configured in https://github.com/w3c/github-notify-ml-config
Received on Friday, 28 August 2020 14:42:31 UTC

This archive was generated by hypermail 2.4.0 : Tuesday, 5 July 2022 06:42:13 UTC