Re: [csswg-drafts] [css-ruby] Be more specific about the box model of base/annotation container boxes (#4937)

> But I think this should be kept as implementation details

If it results in a different layout, it's not implementation details.

>> but curiously, it does not ignore the inline margin on base container boxes. I suspect that's an accident,

> That doesn't match my read of the code, the discussion on the implementing ticket, as well as my testing. Could you provide your test code for this?

See the 6th and 7th base/annotation pairs in the https://github.com/web-platform-tests/wpt/pull/22843

> But I think that also raise a question on what does margin box really means for ruby base box and ruby text box. They otherwise behave like inline element, so should their block margin counts in their margin box?

I think it should:
* The definition is clear: The spec says the base/annotation container box should wrap around the base/annotation's margin box, and the margin box is defined to include the margin in all directions
* The definition is useful: This gives us the ability to control the distance between the bases and the annotations, which is an important feature.

It's true that it makes them not entirely the same as inline boxes, but even if they have a number of similarities, they're not entirely the same anyway.

-- 
GitHub Notification of comment by frivoal
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/4937#issuecomment-612001143 using your GitHub account

Received on Friday, 10 April 2020 12:05:16 UTC