Re: [csswg-drafts] [web-animations-1][web-animations-2] Move mutable timelines to web-animations-2 (#4304)

> (Can't get github to actually show me the comment in the file, I think because it must have been made outside of the diff range? Not sure; clicking 'View changes' on your comment shows me nothing at all...)

I think I probably made it as a review comment as opposed to an inline comment.

> I'm undecided about this. It is still used in the `Animation (effect, timeline)` constructor. That said, the timeline can't change so the steps there are probably irrelevant (have not confirmed yet). I'll need to convince myself that `setting the timeline of an animation` can't change anything during the `Animation` constructor, will look at that today :)

I was just going off where bikeshed said that procedure was linked-to from. I didn't actually check the constructor itself so if it is used there, then we should probably leave it in level 1.

-- 
GitHub Notification of comment by birtles
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/pull/4304#issuecomment-531776866 using your GitHub account

Received on Monday, 16 September 2019 13:29:45 UTC