Re: [csswg-drafts] [css-transforms-1] Correct translation calculation in recomposition of decomposed transform (#4446)

I think this is right, and this is a bug in the spec.

Firefox code is [here for decomposition](https://searchfox.org/mozilla-central/rev/e8e4a8641f3e6728ea42ae30905ce2145bfd5568/servo/components/style/values/animated/transform.rs#158), and [here for recomposition](https://searchfox.org/mozilla-central/rev/e8e4a8641f3e6728ea42ae30905ce2145bfd5568/servo/components/style/values/animated/transform.rs#228).

I found some other bugs in the 3d algorithm when dealing with compat issues (https://github.com/w3c/csswg-drafts/pull/2713 for example).

But yeah, I think the spec as written doesn't preserve the matrix across decomposition and recomposition, which is clearly a bug.

cc @dirkschulze 

-- 
GitHub Notification of comment by emilio
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/pull/4446#issuecomment-549125067 using your GitHub account

Received on Sunday, 3 November 2019 10:56:59 UTC