W3C home > Mailing lists > Public > public-css-archive@w3.org > March 2019

Re: [csswg-drafts] [css-inline] A question for the procedure to compute the used value of "line-height" (#3749)

From: joonghunpark via GitHub <sysbot+gh@w3.org>
Date: Wed, 20 Mar 2019 04:46:33 +0000
To: public-css-archive@w3.org
Message-ID: <issue_comment.created-474683062-1553057192-sysbot+gh@w3.org>
I see. Then current blink behavior returning "normal" keyword instead of px
value for "line-height" is reasonable I think.
In that case, in https://drafts.csswg.org/cssom/#resolved-values, it seems
that "line-height" should be excluded from the css property list of "used
value is resolved value".
Thank you for your help.

2019년 3월 20일 (수) 오후 12:57, Florian Rivoal <notifications@github.com>님이 작성:

> The logic for line-height described in css2.1 is know to be buggy.
>
> It has been quite thoroughly reviewed and fixed, and css2.2 was made
> reliable. There remained some unsolved questions forline-height: normal,
> but it is a lot less wrong than what came before it.
>
> However, for unrelated reasons (insufficiently careful edits had been made
> throughout the spec, so various parts were wrong, and which was which had
> become intractable), all changes to css2.2 had to be reverted to css2.1. We
> still haven't been able to re-apply all the known-to-be good changes.
>
> This means the better definition of line height is currently in no spec at
> all. We should fix that, but until that happens, I recommend reading form
> the PR that did fix it at some point: #1993
> <https://github.com/w3c/csswg-drafts/pull/1993>, while keeping an eye for
> possible issues. I'm aware of at least these:
>
>    - #1254 <https://github.com/w3c/csswg-drafts/issues/1254> (This one is
>    partly solved, so you may want to skip the first half of the issue, but as
>    the comments after #1254 (comment)
>    <https://github.com/w3c/csswg-drafts/issues/1254#issuecomment-296129092>
>    show, there are still some unresolved points)
>    - #2418 <https://github.com/w3c/csswg-drafts/issues/2418>
>    - #1551 <https://github.com/w3c/csswg-drafts/issues/1551>
>
> Based on all that, I am not sure that what you're trying to do is
> possible: unlike the other values of the property, line-height: normal
> does not result in single a height per element. Each text run may end up
> having a different height. To me, that means that returning 'normal' as a
> keyword makes more sense. Unless there's a compat constraint, I think CSSOM
> should be fixed accordingly (non-normal values should still be absolutized,
> but normal should stay as a keyword).
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/w3c/csswg-drafts/issues/3749#issuecomment-474675234>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ACmEJmGO3W5IDa61c9sHB_DBD3epNy88ks5vYbGsgaJpZM4b9b3c>
> .
>


-- 
GitHub Notification of comment by joonghunpark
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/3749#issuecomment-474683062 using your GitHub account
Received on Wednesday, 20 March 2019 04:46:35 UTC

This archive was generated by hypermail 2.4.0 : Thursday, 24 March 2022 20:26:58 UTC