W3C home > Mailing lists > Public > public-css-archive@w3.org > March 2019

Re: [csswg-drafts] [css-grid] Unintentional change to grid container baseline? (#3645)

From: CSS Meeting Bot via GitHub <sysbot+gh@w3.org>
Date: Wed, 13 Mar 2019 16:35:31 +0000
To: public-css-archive@w3.org
Message-ID: <issue_comment.created-472502461-1552494927-sysbot+gh@w3.org>
The CSS Working Group just discussed `Unintentional change to grid container baseline?`, and agreed to the following:

* `RESOLVED: Change the algorithm take baseline from the first grid content instead of synthesize from first row`

<details><summary>The full IRC log of that discussion</summary>
&lt;dael> Topic: Unintentional change to grid container baseline?<br>
&lt;dael> github: https://github.com/w3c/csswg-drafts/issues/3645<br>
&lt;dael> fantasai: Error I want to revert at least. What would we expect baseline alignement of grid with a single item in 2nd row. We can use the first item in the first row for where we derive baseline from<br>
&lt;dael> fantasai: I think we should do the baseline of the first available grid item even if not on first row, but wanted to check<br>
&lt;dael> astearns: Prefer FF behavior. Better to take baselines we have then punt<br>
&lt;dael> astearns: Looking through comments to see if anybody disagrees<br>
&lt;dael> astearns: Only thing javier brings up is if there's no content in first track you can synthesize<br>
&lt;dael> fantasai: If no content in grid we synthesize.<br>
&lt;dael> fantasai: Question is if we have an empty row do we look at next row?<br>
&lt;dael> AmeliaBR: When first item is it grid layout order?<br>
&lt;dael> fantasai: Yes<br>
&lt;dael> AmeliaBR: First item in DOM is in a different row we skip over that and focus on rows and columns?<br>
&lt;dael> fantasai: Yes<br>
&lt;dael> astearns: Looks like I was confused on rows and columns<br>
&lt;dael> astearns: There's an actual difference in opinion between impl<br>
&lt;dael> fantasai: jensimmons rachelandrew opinions?<br>
&lt;dael> jensimmons: Not really<br>
&lt;dael> astearns: If the first track is empty then is the design using that track for space?<br>
&lt;dael> astearns: In which case does aligning grid on 2nd track baseline void that decision?<br>
&lt;dael> fantasai: If you're using it for space, we've seen cases to use first track to make padding, seems reasonable to use the content of the 2nd row in that case<br>
&lt;dael> astearns: First track is for padding if grid is not baseline align?<br>
&lt;dael> fantasai: We have a grid with an empty first row and content in 2nd row. Do we treat this grid as not having baseline or do we take baseline from 2nd row. That's the question<br>
&lt;dael> jensimmons: How would that effect sizing of first row?<br>
&lt;dael> fantasai: Doesn't. Effects how that grid aligns with other content. If you have grid inside a table cell and another grid next to it<br>
&lt;dael> rachelandrew: In that example 2nd row makes sense. It does seem using first row as padding is the common case. Trying to think if other cases<br>
&lt;gregwhitworth> Agreed with fantasai and rachelandrew<br>
&lt;dael> astearns: If you have 2 grids in adjacent table cells and you are using the first row for space in the first grid and both have a BG color so you can see the space added if those 2 are not baseline aligned then the content in the first is pushed down by the amount of first row. If you do baseline align the 2 table cells the first grid's space is maintained and push table height up in FF case. In chrome case space is maintained and push table cell height down<br>
&lt;dael> astearns: That's the case for this in a concrete case<br>
&lt;dael> [mic problems with someone, possibly fantasai ]<br>
&lt;fantasai> [not me]<br>
&lt;dael> astearns: I think it does make a bit more sense to take baseline from first available content in the grid. I don't know that it is something that is going to be used often. Prob an edge case that will not come up often<br>
&lt;dael> jensimmons: I think it might come up. Not sure edge case. I can see real world use cases for this. not 2 grid items in a table cell, but 2 grid items in a grid<br>
&lt;dael> astearns: Or a flex container. Or if we get to baseline aligning in other cases<br>
&lt;dael> jensimmons: Options is align second row with other grid or...?<br>
&lt;dael> astearns: Options are at moment algo says you take baseline of content in first row and if there isn't you synthesize. So if first row is empty spec sasy you synthesize a baseline. Considering saying take first content in grid and use that for baseline<br>
&lt;dael> jensimmons: Result of synthezation? Just make up a line? I guess yes<br>
&lt;dael> rachelandrew: I can think of using baseline of first content item, that can be explained. You can say you haven't got content in the first track so we're using first item to work out baseline. Being worked out on something that doesn't exist is harder to explain. As someone who explains this stuff to people ut's easier to work off first item that appears<br>
&lt;dael> jensimmons: Lean that way too. I can see where people would make sep grids, put in a grid, and then align baselines. At this point you can't have an empty row with a visual thing. But if we get to where you can style grid rows there's a case to show on nothingness<br>
&lt;dael> astearns: Will show if there's border or BG<br>
&lt;dael> jensimmons: I lean toward do the first row with content in it. THat makes sense as an author. I think that's what rachelandrew is saying<br>
&lt;bkardell_> it is what I would expect too<br>
&lt;dael> astearns: Converging on take baseline from the first grid content instead of synthesize from first row<br>
&lt;dael> astearns: Objections to take baseline from the first grid content instead of synthesize from first row and see how Blink and WK impl take to it?<br>
&lt;jensimmons> I also think this makes baseline alignment more useful<br>
&lt;dael> RESOLVED: Change the algorithm take baseline from the first grid content instead of synthesize from first row<br>
</details>


-- 
GitHub Notification of comment by css-meeting-bot
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/3645#issuecomment-472502461 using your GitHub account
Received on Wednesday, 13 March 2019 16:35:32 UTC

This archive was generated by hypermail 2.4.0 : Tuesday, 19 October 2021 01:31:05 UTC