W3C home > Mailing lists > Public > public-css-archive@w3.org > February 2019

Re: [csswg-drafts] [css-grid] Resolving percentage heights of grid items during min-content sizing (#2674)

From: fantasai via GitHub <sysbot+gh@w3.org>
Date: Wed, 20 Feb 2019 09:14:43 +0000
To: public-css-archive@w3.org
Message-ID: <issue_comment.created-465490328-1550654081-sysbot+gh@w3.org>
> please confirm that you mean "when calculating a min-content or min-size contribution" rather than just "when calculating the min-content contribution" for replaced boxes ([under the second bullet](https://drafts.csswg.org/css-sizing-3/#percentage-sizing)).

Fixed s/computed size/used size/ and s/specified/preferred/ in https://github.com/w3c/csswg-drafts/commit/8d71a739c79d3da828e9fe6a0f1eb3584b1d2d01

> Also, it's currently undefined how percentages should be calculated when calculating a _max-content contribution_ for replaced boxes. Presumably the spec should say that they _behave as auto_ there.

Added missing case in https://github.com/w3c/csswg-drafts/commit/c0a4c578

> If you want image grid items with a percentage preferred size to contribute zero to the track base size then I think you need to include [min-size contribution](https://drafts.csswg.org/css-grid/#min-size-contribution) too.

Attempted to fix via https://github.com/w3c/csswg-drafts/commit/534f79283a4687a5f0bc722baed5792e2c54433a

@MatsPalmgren Let me know if anything here still seems unresolved.

Agenda+ for review of that last fix, to make the cyclic percentage rules that zero out percentages apply to automatic minimum size calculations, making the “specified size suggestion” definite (and equal to zero, in the case of a pure percentage).

-- 
GitHub Notification of comment by fantasai
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/2674#issuecomment-465490328 using your GitHub account
Received on Wednesday, 20 February 2019 09:14:45 UTC

This archive was generated by hypermail 2.4.0 : Tuesday, 5 July 2022 06:41:43 UTC