Re: [csswg-drafts] [css-color-adjust-1] Disallow repetition of color-scheme keywords? (#3848)

Yeah, storing it as a bitset is also incompatible with preserving unknown identifiers, afaict.

FWIW, the way will-change and such is implemented in Firefox is keeping the known properties in a bitfield, and the specified value in a separate array. So you pay a bit more memory (on byte) more than the array of names, but get fast checking:

  https://searchfox.org/mozilla-central/rev/ec489aa170b6486891cf3625717d6fa12bcd11c1/servo/components/style/values/specified/box.rs#669

But it's not clear to me that's what @lilles refers to, necessarily... Not sure how not keeping duplicated names helps to handle color scheme changes dynamically. I'd be curious to know though :)

-- 
GitHub Notification of comment by emilio
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/3848#issuecomment-486018295 using your GitHub account

Received on Wednesday, 24 April 2019 00:07:43 UTC