- From: Florian Rivoal via GitHub <sysbot+gh@w3.org>
- Date: Thu, 22 Mar 2018 02:09:11 +0000
- To: public-css-archive@w3.org
I am so confused at how github works. Why is it that I made this commit, you merged it, and the commit history [shows you as the author of this commit](https://github.com/w3c/csswg-drafts/commit/3a640ed2403d3a4002f629bcb7189021bd524265)? Not of the merge commit, of the actual commit. I noticed because [twitter told me](https://twitter.com/CSScommits/status/976619788431749120) you fixed this, and I was wondering why you didn't merge the commit I had made. Maybe I had got it wrong somehow? I cannot read Thai, so it is very possible. But no, it turns out you did merge my PR, but github claims you wrote it. Probably a side effect of rebase-and-merge? I don't care about being given credit for this particular commit, but I it seems bad that github seems to be messing with attribution in general. Beyond affecting who gets credit, it will also hide that the spec has external contributors when their Pull Requests get merged by WG members, which seems problematic from an IP point of view. @fantasai did you do something unusual when merging this, making my worries about github unfounded? -- GitHub Notification of comment by frivoal Please view or discuss this issue at https://github.com/w3c/csswg-drafts/pull/2457#issuecomment-375155170 using your GitHub account
Received on Thursday, 22 March 2018 02:09:21 UTC