Re: [csswg-drafts] [css-overflow] Consider support for multiple-line ellipsis

Hi all,

@rakuco and I are looking into normative spec changes that don't have tests this quarter, in this [tracking doc](https://docs.google.com/document/d/1kFYTqUMEbo9p87i6wAzORoicMWgHsuYwL2CgtvdhDaE/edit?usp=sharing), and this week I ended up here via https://github.com/w3c/csswg-drafts/commit/41bdbcd24. (The point of the exercise is to understand what might still be missing to make testing the web platform easier.)

The string "webkit-line-clamp" doesn't appear anywhere in web-platform-tests, and "line-clamp" appears in these places:
css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-single-line-clamp-1.html
css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-single-line-clamp-2.html
css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-single-line-clamp-3.html

Per https://wpt.fyi/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox those are all passing in everywhere, but I don't know how deep they go.

@frivoal, do you have some sense for the required test coverage for (-webkit-)line-clamp? Would it be useful to just add a test that ensures that the webkit property is supported? `'webkitLineClamp' in document.body.style` is the most trivial thing possible. A proper test would set `style.webkitLineClamp` and see what happens to `style.lineClamp`, but it looks like only Chrome and Safari support the prefixed property, and nobody the unprefixed one...

-- 
GitHub Notification of comment by foolip
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/390#issuecomment-372868133 using your GitHub account

Received on Wednesday, 14 March 2018 00:50:46 UTC