W3C home > Mailing lists > Public > public-css-archive@w3.org > September 2017

Re: [csswg-drafts] [css-flexbox][css-grid] Intrinsic sizing with ∑flex < 1 is broken

From: fantasai via GitHub <sysbot+gh@w3.org>
Date: Thu, 14 Sep 2017 16:15:03 +0000
To: public-css-archive@w3.org
Message-ID: <issue_comment.created-329532806-1505405693-sysbot+gh@w3.org>
Proposed changes to address @dholbert‘s last two comments:

```
diff --git a/css-flexbox/Overview.bs b/css-flexbox/Overview.bs
index afcb32f..8a8edfc 100644
--- a/css-flexbox/Overview.bs
+++ b/css-flexbox/Overview.bs
@@ -2797,13 +2797,15 @@ Flex Container Intrinsic Main Sizes</h4>
 
                <li>
                        For each <a>flex item</a>,
-                       subtract its outer <a>flex base size</a> from its [[#intrinsic-item-contributions|max-content contribution]] size.
+                       find its <var>max-content flex fraction<var>:
+                       Subtract its outer <a>flex base size</a> from its [[#intrinsic-item-contributions|max-content contribution]] size.
                        If that result is positive,
                        divide by its <a>flex grow factor</a> floored at 1;
                        if negative,
-                       by its <a>scaled flex shrink factor</a>
-                       having floored the <a>flex shrink factor</a> at 1.
-                       This is the item's <var>max-content flex fraction</var>.
+                       by its <a>flex shrink factor</a> floored at 1
+                       multipled by its <var>flex base ratio</var>--
+                       the ratio of its <a>flex base size</a>
+                       to the sum of the <a>flex base sizes</a> of all shrinkable items on the line.
 
                <li>
                        Within each line,
@@ -2819,7 +2821,8 @@ Flex Container Intrinsic Main Sizes</h4>
                <li>
                        Add each item’s <a>flex base size</a>
                        to the product of its <em>rescaled</em> <a>flex grow factor</a>
-                       (or <em>rescaled</em> <a>scaled flex shrink factor</a>,
+                       (or its <em>rescaled</em> <a>flex shrink factor</a>
+                       multiplied by its <var>flex base ratio</a>,
                        if the chosen <var>max-content flex fraction</var> was negative)
                        and the chosen <var>max-content flex fraction</var>,
                        then clamp that result by the <a>max main size property</a>
```

This change switches us back to using flex shrink factors in place of scaled shrink factors, and introduces the concept of flex base ratio as a multiplier instead.

-- 
GitHub Notification of comment by fantasai
Please view or discuss this issue at https://github.com/w3c/csswg-drafts/issues/1735#issuecomment-329532806 using your GitHub account
Received on Thursday, 14 September 2017 16:14:57 UTC

This archive was generated by hypermail 2.4.0 : Tuesday, 5 July 2022 06:41:18 UTC